supabase / supabase-flutter / 39956826359

94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(typegen): disambiguate embeds of opposite-direction keys and junction tables, alias embeds named like columns (#2020)

Fixes
[SDK-2359](https://linear.app/supabase/issue/SDK-2359/fixtypegen-generated-embeds-are-ambiguous-for-opposite-direction).

## Problem

Some foreign key shapes produced embeds that PostgREST could not serve:

1. **Keys in opposite directions.** With `profile.team -> team` and
`team.owner_id -> profile`, the generator only added a `!fkey` hint when
two keys pointed the same way. `Profile.teamByTeam` and
`Profile.teamViaOwnerId` both sent `select=team(*)`, which PostgREST
rejects with `PGRST201`.
2. **Embed keys named like a column.** With `badge.profile -> profile`,
`selectOnly([Badge.profile, Badge.profileByProfile.select()])` sent
`select=profile,profile(*)`. The response then carries a duplicate
`profile` key, so reading the column fails.
3. **A key next to a junction table** (found in review, and the case the
ticket names as the most common). With `badge.team -> team` and a
`team_badge` junction whose primary key covers its keys to both tables,
PostgREST sees a many-to-one and a many-to-many relationship, so the
unhinted `team(*)` is ambiguous too.

All three were reproduced against the local stack before the fix.

## Fix

- The generator counts the relationships PostgREST sees between each
pair of tables once per run. That covers foreign keys in either
direction, plus many-to-many relationships through a junction table
whose primary key covers a key to each table. A unique constraint is not
enough, which was verified on the stack. A relation carries the hint
whenever its pair has more than one relationship.
- An embed is aliased to its member name in snake case when it is hinted
(as before) or when its plain key is also the name of a column or
computed field of the table. Aliases are still kept apart from every
other key of the table.

Generated member names do not change. Embeds of the affected shapes now
resolve and come... (continued)

Coverage Stats

41 of 41 new or added lines in 1 file covered. (100.0%)

126 existing lines in 7 files now uncovered.

11449 of 12416 relevant lines covered (92.21%)

5.62 hits per line