supabase / supabase-flutter / 39956578220

93%

Build Type

push

github

Committed by web-flow

Commit Message

fix(supabase_common): cancel the retry backoff on abort and honour long Retry-After and jitter at the cap (#2043)

Linear:
https://linear.app/supabase/issue/SDK-2355/fixsupabase-common-retry-loop-leaks-its-backoff-timer-on-abort-and

Fixes the shared retry loop in `supabase_common` and the exception names
it surfaced.

## Changes

1. **An abort cancels the backoff timer.** The wait between attempts is
now a `Timer` that the abort signal cancels, so an aborted call no
longer leaves a timer pending for up to `maxDelay`. That pending timer
is what failed widget tests with "A Timer is still pending" and kept
scripts from exiting.
2. **A `Retry-After` longer than `maxDelay` is not retried.** The loop
used to cut it down to `maxDelay`, so a `503` with `Retry-After: 120`
was retried after 30 seconds, three times. Now the exception is
rethrown, or the result returned, without retrying. Auth cut the header
down itself in `_refreshAccessToken` before handing it to `retry`, so
that cap is removed too.
3. **Jitter is applied after the cap.** Delays that reach `maxDelay`
used to all be exactly `maxDelay`. They are now randomized like every
other delay.
4. **An abort signal that fails ends the loop with
`RequestAbortedException`**, as the dartdoc says, instead of rethrowing
the signal's own error.
5. **`Retry-After: 0` falls back to the backoff**, for the same reason a
date in the past already did. A refresh answered with a 429 is only
retried within the tick when its `Retry-After` asks for a wait, so a 429
with `Retry-After: 0` now keeps the session and waits for the next tick,
like a 429 without the header.
6. **The `SupabaseRetryOptions` class doc lists what is actually
retried.** PostgREST also retries reads after a network error, and auth
also retries `5xx` responses.
7. **Exception `toString` uses literal class names.** Item 7 was marked
unconfirmed in the ticket. A program compiled with `dart compile js -O2`
and `-O4` printed `minified:a2(...)` for `'$runtim... (continued)

Coverage Stats

26 of 28 new or added lines in 8 files covered. (92.86%)

100 existing lines in 7 files now uncovered.

10203 of 11092 relevant lines covered (91.99%)

5.97 hits per line