supabase / supabase-flutter / 39927507934

94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(postgrest)!: send DateTime filter operands with their offset from UTC (#2024)

Fixes
[SDK-2335](https://linear.app/supabase/issue/SDK-2335/fixpostgresttypegen-send-datetime-filter-operands-in-utc).

A local `DateTime` in a filter went out without an offset, so a
`timestamptz` filter compared against an instant shifted by the device
offset. The typed filters sent `toIso8601String()`
(`gt.2026-01-01T12:00:00.000`) and the untyped ones sent `toString()`
(`gt.2026-01-01 12:00:00.000`). The generated column tokens and typed
RPC `GET` arguments go through the same renderer. Range literals had the
same problem with `DateTime` bounds.

## Changes

- `postgresTimestampLiteral` in `supabase_common` renders a `DateTime`
in ISO 8601 with its offset from UTC: `Z` for a UTC value, the local
offset at that instant for a local one
(`2026-01-01T12:00:00.000-05:00`).
- It is used by:
- the typed filter renderer (column tokens, `inFilter`, array literals,
realtime filters through `PostgrestComparison.renderedValue`) and `GET`
function arguments
- the `DateTime` bounds of `PostgresRange.literal`, and so of
`PostgresMultirange`
- `PostgresChangeFilter`, so an untyped `stream()` subscribes with the
same value its initial fetch filtered by
- The untyped `PostgrestFilterBuilder` now renders its operands with the
same `renderPostgrestQueryValue` as the typed filters. This covers every
scalar and list operand (`eq`, `neq`, `gt`, `gte`, `lt`, `lte`, `not`,
`filter`, `match`, `isDistinct`, `inFilter` and the other list filters)
and the non-string operand of `contains`, `containedBy` and `overlaps`.
Beyond `DateTime`, this means a `Uint8List` is sent as a `bytea` literal
and a `PostgresValue`, such as a `PostgresRange`, as its literal, where
the untyped builder used to send `toString()` or throw from
`json.encode`. A `Map` is still sent as JSON.
- A year past 9999 is written without the leading `+` ISO 8601 adds,
because Postgres rejects `+010000-01-01T00:00:00.000Z`.
- MIGRA... (continued)

Coverage Stats

51 of 51 new or added lines in 6 files covered. (100.0%)

109 existing lines in 11 files now uncovered.

11247 of 12235 relevant lines covered (91.92%)

5.51 hits per line