supabase / supabase-flutter / 39926427044

94%

push

github

refactor(yet_another_json_isolate)!: drop initialize(), align web and IO behavior, and keep small toJson objects off the isolate (#2041)

Resolves
[SDK-2351](https://linear.app/supabase/issue/SDK-2351/refactoryet-another-json-isolate-drop-initialize-align-web-and-io).

## Changes

### `initialize()` is removed

It was a no-op kept for backwards compatibility that still asserted on a
second call. It is gone from both implementations, from
`sdk-compliance.yaml`, and from the callers in `postgrest`,
`supabase_functions`, `supabase`, the benchmark and the example. The
MIGRATION.md snippet no longer calls it, and the JSON codec section says
to delete the call.

### Web and IO behave the same

- The web constructor is no longer `const`, and it exposes `debugName`
like the IO one.
- On web, `dispose()` now makes later calls throw a `StateError`, as IO
already did.
- Web `encode` awaited before encoding, so a caller could mutate the
value before it was read. That broke the `AsyncJsonCodec` contract. It
now encodes synchronously, like the IO inline path.

### Web runs inline, and the docs say so

The library doc, README, pubspec description and web class doc now state
that on web every payload is processed inline on the main thread.

### `toJson()` runs on the calling isolate

`encode` makes one pass over the value on the calling isolate. It
replaces objects that are not JSON values with the result of their
`toJson()` method and estimates the encoded size at the same time,
replacing the separate size walk. A small model object is now encoded
inline instead of spawning an isolate, and `toJson` runs on the calling
isolate once for each place the object appears, so its side effects
happen where the caller expects them. Lists and maps are only copied
when something inside them is replaced.

A value that cannot be encoded is encoded inline, so `jsonEncode` throws
exactly the error it always did, without an isolate spawn. Values that
cannot be encoded include a `toJ... (continued)

46 of 47 new or added lines in 4 files covered. (97.87%)

10747 of 11719 relevant lines covered (91.71%)

5.39 hits per line