rpm-software-management / spec-cleaner / 39915520878

99%

push

github

Keep BuildRoot: in minimal mode; the full run keeps removing it

The minimal (service) run removed BuildRoot: along with the other
deprecated preamble tags. Per the ruling on #473, the removal is
gated to the full run: the service run leaves the tag in place and
full runs keep the tidy.

In minimal mode the tag is stored under its own preamble category
and emitted as written; the category takes the slot between
removepath and buildarch in categories_order. The full run removes
the tag, and comments attached to it, exactly as before.

Corpus verification (100-spec systematic sample of the 1,888
Factory specs whose BuildRoot: the old minimal run dropped): the
new minimal run retains the tag in all 100 sampled specs and the
retained lines match the originals exactly. The old-to-new delta
is 104 added lines and none removed: the 100 tags, 2 conditional
delimiters (one spec where the tag was a conditional's sole
content) and 2 comments attached to retained tags, which the old
run dropped together with the tag.

Tests: a buildroot fixture trio pins the three corpus value
shapes across the main preamble and two subpackages, a comment
attached to the tag, retention in minimal mode and removal in the
full run; a buildroot-absent trio pins the no-tag case with
byte-identical outputs in both modes; six existing minimal
expectations regain exactly their BuildRoot: line (in two of them
the conditional that held only the tag reappears with it). Full
suite: 794 passed (790 on master); coverage unchanged at 21
missed statements, with both new production lines covered.

3 of 3 new or added lines in 1 file covered. (100.0%)

2641 of 2662 relevant lines covered (99.21%)

4.96 hits per line