decentraland / atlas-server / 39825659993

94%

Build Type

push

github

Committed by web-flow

Commit Message

fix: serve filtered tiles, bound the response cache and add timeouts (#149)

## What was wrong

- With `atlas-redirect-to-s3` on, `/v1|v2/tiles` returned the 301 before
reading `x1/y1/x2/y2/include/exclude`, so a filtered prd request
downloaded the full 38 MB map.
- The tiles were uploaded to S3 as plain JSON (38 MB per refresh and per
client download), with `Access-Control-*` written as object metadata (S3
serves that as `x-amz-meta-*`, not CORS).
- The tiles response cache was an unbounded `Map` keyed by the full URL
(host + junk params), cached 503s and 301s, and ran the handler once per
concurrent miss.
- `createFeaturesComponent` had no registered apps, so flags were never
cached: every cache miss fetched `dapps.json` (10s timeout) and a
failure silently disabled the redirect.
- The redirect URLs were set from the S3 cache at boot and never cleared
when an upload failed, so clients could be redirected to stale files.
- No timeout on Postgres queries, S3 requests or signatures-server
rentals requests.

## What changed

- The S3 redirect (now a 302) is decided per request and only when no
filter actually applies (a full numeric bounding box, or include/exclude
with a valid field); filtered requests are served from memory.
- v1/v2 tiles are uploaded gzip-compressed with `ContentEncoding: gzip`
(~3 MB). The boot read gunzips gzip objects and still reads the old
plain ones. Metadata dropped, `console.log` replaced with the logger.
- `cacheWrapper`: holds only 200s from memory, keyed on the normalized
effective filter, cleared when `getLastUpdatedAt` changes, LRU-capped at
128 entries / 64M body chars, shares in-flight misses.
- Features component registers `dapps`, so flags are preloaded and
refreshed in the background.
- Redirect URLs are set only after the whole upload (v1, v2, timestamp)
succeeds, and cleared on failure.
- `PG_COMPONENT_QUERY_TIMEOUT=60000`, S3 `requestTimeout` 60s /
`connectionTimeout` 5s, rentals fetch `timeout: 30000` plus a 30s... (continued)

Coverage Stats

1344 of 1474 branches covered (91.18%)

Branch coverage included in aggregate %.

321 of 331 new or added lines in 7 files covered. (96.98%)

2 existing lines in 2 files now uncovered.

4530 of 4835 relevant lines covered (93.69%)

1094.63 hits per line