solidjs / solid / 39860244179

78%

main: 89%

push

github

fix(web): renderToStream completes when a value fails to serialize synchronously (#4229)

* fix(web): renderToStream completes when a value fails to serialize synchronously

A value the serializer cannot handle, handed over already settled (a
`deferStream` value, a `getHydrationWriter().write`), fails inside the
write. seroval 1.6's `Serializer` never reaches that write's `onDone`,
so `flush()` never completed: the hook heard `render/serialize`, but the
render stayed pending, the piped stream never ended and the final
dispose never ran. `createJSONSerializer` had the same gap in its own
bookkeeping.

Both serializers now share one keyed writer. A write settles on its
`onDone`. A write whose value fails inside the call, so that no initial
chunk goes out, is disposed and settled when the call returns. Other
failures (a promise, a stream chunk, buffered or not) still settle on
`onDone`, as before, and a `close()` from inside a write disposes it
too. The hydration serializer runs on `crossSerializeStream` with the
same output as seroval's `Serializer`; `createSerializer` is unchanged.

* fix(web): settle a write that throws when the serializer has no onError

Without `onError`, seroval throws a synchronous failure out of the write
instead of reporting it. The exception still reaches the caller
(`renderToString` relies on that), but the write stayed counted as
pending, so a later `flush()` never called `onDone`. The keyed writer
now settles the write before rethrowing.

* fix(web): leave serializeErrorStacks out of the hydration serializer's options

`createHydrationSerializer` pins its feature policy and never read
`serializeErrorStacks`, so passing it did nothing: hydration stacks
follow `NODE_ENV`. The options type now leaves it out, like
`globalIdentifier` and `disabledFeatures`. No runtime change.

* test(web): share the settle harness between the renderToStream failure specs

The #4193 spec and the new one copied `watchEscapes`, `settle` and
`pipeSet... (continued)

771 of 1066 branches covered (72.33%)

Branch coverage included in aggregate %.

1114 of 1358 relevant lines covered (82.03%)

27.6 hits per line