opendefensecloud / solution-arsenal / 39783242068
79%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 100
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 79.513% (-0.04%) from 79.557%
39783242068

push

github

web-flow 
chore: clean up leftovers from the Component type removal (#883)

## What

Non-behavioral cleanup, mostly leftovers from removing the Component API
type (948c2e0c).

- `cmd/solar-discovery/main.go:29` -> help text still said it writes a
"Component or ComponentVersion", plus "coresponding"
- `pkg/controller/target_controller.go:58,701,709` -> dedup fallback
described as "the parent Component name from the CV", it is
`cv.Spec.ComponentName` (the OCM component name, see
`effectiveUniqueName` in `helpers.go:119`)
- `docs/developer-guide/rendering-pipeline.md:75` -> same phrase
- `test/e2e/e2e_test.go:221` -> "namesspaces"

## Why

Found while sweeping the Go code for nitpicks. The help text is
user-facing and points at a type that no longer exists.

Left alone on purpose:
- ADR 004 still says "parent Component name". Its a decision record, so
it keeps the wording of its time
- British spellings (`cancelled`, `labelled`, `behaviour`, ...), our
misspell config does not enforce a locale
- `gopls` reports nothing in hand-written code, only in generated
`client-go/` and `zz_generated*` files

## Testing

No behavior change, comments, one help string and one `By()` label.

```console
$ go build ./... && go vet ./cmd/solar-discovery ./pkg/controller && go vet -tags e2e ./test/e2e
$ echo $?
0
```

## Checklist
- [x] Tests added/updated, or confirmed that no tests are required (no
behavior change)
- [x] No breaking changes, or upgrade path documented above
- [x] Readable commit history (squashed and cleaned up as desired)
- [ ] AI code review considered and comments resolved

5387 of 6775 relevant lines covered (79.51%)

33.81 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
86.64
-0.43% pkg/controller/rendertask_controller.go
2
78.37
-0.19% pkg/controller/target_controller.go
Jobs
ID Job ID Ran Files Coverage
1 39783242068.1 100
79.51
GitHub Action Run
Source Files on build 39783242068