opendefensecloud / solution-arsenal / 39598200574

79%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(controller): make condition reasons constants (#885)

## What
Condition reasons in the controllers are now `Reason*` constants next to
the `ConditionType*` ones. Controllers and unit tests use them, string
values are unchanged.

## Why
Reasons are part of the status contract -> a typo or rename in a literal
silently breaks consumers. `NotGranted`, `NotFound` and `Resolved` are
shared by the Release and Target reconcilers, so they live once in
`release_controller.go`.

e2e keeps the literals on purpose, its a black-box check of the wire
values.

## Testing
Pure refactor, no behavior change.

```
$ go build ./... && go vet ./pkg/controller/
$ go test ./pkg/controller/
ok  	go.opendefense.cloud/solar/pkg/controller	198.147s
```

## Checklist
- [x] Tests added/updated (assertions switched to the constants)
- [x] No breaking changes
- [x] Readable commit history (squashed and cleaned up as desired)
- [x] AI code review considered and comments resolved

Closes #860

Coverage Stats

31 of 38 new or added lines in 5 files covered. (81.58%)

1 existing line in 1 file now uncovered.

5390 of 6775 relevant lines covered (79.56%)

34.29 hits per line