romshark / datapages / 39691839174

53%

Build Type

push

github

Committed by romshark

Commit Message

fix: Count every unrecovered internal error

Before: datapages_internal_errors_not_recovered_total counts an error
only when RecoverError returns an error or panics. The errors of page
loads, file actions and apps without RecoverError count nowhere,
and neither does a panic after the response started.
The help text promises an HTTP error response,
which a failed RecoverError never sends,
since its event stream keeps status 200.

After: the counter counts all of these. An error counts once in 1 of
the 2 counters, as recovered only when RecoverError handles it,
and a sentinel counts like any other error.
The help texts say which errors each counter counts.

Coverage Stats

32 of 44 new or added lines in 5 files covered. (72.73%)

25 existing lines in 7 files now uncovered.

33107 of 63159 relevant lines covered (52.42%)

4362.47 hits per line