ponder-lab / Hybridize-Functions-Refactoring / #3733

89%

push

github

Stop the analysis when a PyDev lookup loses its answer (#1147)

* Stop the analysis when a PyDev lookup loses its answer

A PyDev lookup whose request to a dead completion server got no answer
came back incomplete, often empty, and the analysis carried on as if
nothing had been found: a decorator then went unresolved, for example,
and the results differed without saying so (#1121).

HFR's two PyDev lookups, the definition lookup behind decorator and
type-hint names and the parent-class lookup, now read PyDev's per-thread
lost-answer count before and after the call, on the calling thread and
under the PyDev lock. A change throws a new LostPyDevAnswerError naming
the lookup, its selection, module, file, and project.

It's an Error so the analysis's catches of Exception, which turn a
failed step into a per-function result, let it through. The processor's
final-condition check turns it into a fatal status entry carrying the
error, so the LTK refactoring stops there. The evaluator rethrows it
from that status and from its per-project isolation, and reports the
run as failed rather than as complete.

The test makes PyDev's server die importing a forced builtin, so the
decorator lookup really loses its answer, and asserts the fatal status.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Test a lost answer in the class-hierarchy lookup

The parent-class lookup had no test of its own (#1121). In the new
fixture, a class whose base comes from a forced builtin that kills
PyDev's server has a `call` method, so the analysis asks for the class's
parents, and that lookup's request for the base loses its answer. The
fixture has no decorators, so no definition lookup reaches the module
first. The test asserts the fatal status naming the class-hierarchy
lookup, sharing its setup and assertions with the definition-lookup
test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Clau... (continued)

16 of 16 new or added lines in 4 files covered. (100.0%)

5416 of 6088 relevant lines covered (88.96%)

0.89 hits per line