romshark / datapages / 39644346594

53%

Build Type

push

github

Committed by romshark

Commit Message

fix: Check reflected signals as encoding/json does

Before: datapages gen checks the seed of a reflectsignal query field
against the underlying type of its signal. It refuses an int field
reflected into a *int signal, which encoding/json decodes. For an
int64 signal type with UnmarshalText, it refuses a string field,
which encoding/json passes to UnmarshalText, and accepts an int
field, whose number encoding/json refuses.
Every action that takes the signal then answers 400.

After: a pointer signal accepts what its element type accepts.
A signal that implements encoding.TextUnmarshaler and not
json.Unmarshaler accepts only strings.

Coverage Stats

8 of 8 new or added lines in 1 file covered. (100.0%)

8 existing lines in 2 files now uncovered.

32693 of 62064 relevant lines covered (52.68%)

4438.38 hits per line