stacklok / toolhive / 39636211636

73%

Build Type

push

github

Committed by web-flow

Commit Message

Explain LLM gateway model-discovery failures (#6884)

* Explain LLM gateway model-discovery failures

Model discovery errors told users to pass --models, which neither
helped (a discovery failure still aborted Claude Code setup) nor was
safe: --models is persisted and shared with Pi and Claude Desktop, so
using it to get past a transient failure freezes the tier pins again.

- Return a typed status error and an empty-catalogue sentinel from
  model discovery, and map each to a message naming the likely cause:
  gateway unreachable, wrong path (404), no access (401/403), gateway
  fault (5xx), or no models granted. Pi, VS Code and Claude Code all
  get the clearer messages.
- Treat an Anthropic catalogue with no Bedrock model IDs as a
  discovery failure for bedrock-compat Claude Code, instead of writing
  a config with every tier unpinned. The partial case still warns.
- Let --models that pins every tier bypass a discovery failure,
  matching what lazy mode already accepts.
- Drop the --models hint from discovery-failure messages.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Redact gateway URL in discovery status errors

The gateway URL may carry a password in its userinfo, and the new
status error embeds the models URL in setup diagnostics. Store the
redacted URL so the password never reaches an error or warning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

60 of 60 new or added lines in 2 files covered. (100.0%)

7 existing lines in 4 files now uncovered.

88435 of 123732 relevant lines covered (71.47%)

126.83 hits per line