open-quantum-safe / liboqs / 39620696458

81%

Build Type

push

github

Committed by web-flow

Commit Message

Add QR-UOV signature schemes (#2582)

* Add QR-UOV signature schemes

Signed-off-by: 0rlych1kk4 <orlychikka@gmail.com>

* test(kats): record the 30 missing QR-UOV all digests

Every QR-UOV entry in tests/KATs/sig/kats.json carried only `single`,
while all 77 pre-existing signature entries carry both `single` and
`all`. tests/test_kat_all.py reads `kats[name]['all']` with no guard, so
it failed 30 times with KeyError rather than reporting a data problem.

The digests were computed with the method test_kat_all.py itself uses, a
sha256 over `kat_sig <alg> --all` with CRLF normalised, cross-checked for
one scheme against a direct reimplementation of that test. Each of the
30 outputs also reconstructs to the corresponding published Round 3
PQCsignKAT_32.rsp hash in qruov/round3@3d84d0f, so they are not merely
self-consistent with this tree.

They were computed on an avx2 build. `single` already agrees across ref,
opt and avx2 for all 30, and `--all` differs only in running 100 vectors
where `single` runs one, so the digests should not depend on the
implementation; the matrix added alongside this checks that on ref and
opt rather than assuming it.

test_kats_json.py then makes a missing digest fail as what it is. It
reads the json alone, so it needs no build and runs on every platform,
and it names the algorithms at fault instead of surfacing as a KeyError
inside an unrelated test.

Signed-off-by: paschal533 <okwuosahpaschal@gmail.com>

* test(cmake): fail when an implementation ships that no option can enable

src/sig/qruov/CMakeLists.txt tests OQS_ENABLE_SIG_qruov_<scheme>_opt in
30 places and .CMake/alg_support.cmake declares no such option, so the
condition is false in every configuration. The 30 opt directories, and
the shared qruov_qruov_opt, ship in the tarball and are compiled
nowhere. Nothing notices: the build succeeds and the KATs pass on
whichever implementation was selected, because all three produce
identical vectors.

The check compares the o... (continued)

Coverage Stats

10142 of 10532 new or added lines in 113 files covered. (96.3%)

881 existing lines in 33 files now uncovered.

186417 of 230049 relevant lines covered (81.03%)

4086986.36 hits per line