tari-project / tari / 39587978986
76%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 814
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 76.446% (-0.4%) from 76.818%
39587978986

push

github

web-flow 
fix(identity): check 0600 permissions in load_from_json (#8034) (#8144)

## Description
Resolves #8034.

Calls to `load_from_json` (including the base node and
`minotari_peer_sync` Tor identity loaders) previously checked only that
the target path exists, loading key files silently even if they had
loose permissions (e.g., `0644`). Meanwhile, `load_tor_identity` called
`check_identity_file` but had no callers in the workspace.

This PR:
1. Enforces `check_identity_file(&path)?` inside `load_from_json` when
the file exists, rejecting permissions wider than `0600` with
`IdentityError::InvalidPermissions` (identical to node identity
loading).
2. Maintains `Ok(None)` when the path does not exist so optional
identity loading on fresh startup remains unaffected.
3. Simplifies `load_tor_identity` to delegate directly to
`load_from_json`.
4. Adds unit tests covering:
   - Missing path returning `Ok(None)`.
- Permissions `0644` returning `Err(IdentityError::InvalidPermissions)`.
   - Strict permissions `0600` passing permission checks.

<!-- greptile_comment -->

<!-- greptile_summary -->

<h2><a
href="https://app.greptile.com/api/retrigger?id=84169193"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/RetriggerDark.svg?v=2"><source
media="(prefers-color-scheme: light)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"><img
alt="Retrigger"
src="https://greptile-static-assets.s3.amazonaws.com/badges/Retrigger.svg?v=2"
align="right"></picture></a><a
href="https://app.greptile.com/tari-project/github/tari-project/tari/-/pull/8144"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/ViewInGreptileDark.svg?v=2"><source
media="(prefers-color-scheme: light)"
srcset="https://greptile-static-assets.s3.amazonaws.com/badges/ViewInGreptile.svg?v=2"><img
alt="View in Greptile"
src="https://greptile-static-assets... (continued)

0 of 1 new or added line in 1 file covered. (0.0%)

793 existing lines in 20 files now uncovered.

137394 of 179728 relevant lines covered (76.45%)

401667.91 hits per line

Uncovered Changes

Lines Coverage ∆ File
1
35.71
0.03% applications/minotari_peer_sync/src/main.rs

Coverage Regressions

Lines Coverage ∆ File
287
63.23
-3.87% base_layer/core/src/chain_storage/blockchain_database.rs
266
33.85
-45.7% base_layer/core/src/base_node/rpc/query_service.rs
81
58.62
-1.97% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
39
72.15
-4.11% base_layer/core/src/base_node/sync/horizon_state_sync/synchronizer.rs
25
92.63
-3.69% base_layer/core/src/base_node/sync/header_sync/validator.rs
23
80.29
-2.8% base_layer/core/src/test_helpers/blockchain.rs
13
79.23
-1.01% base_layer/core/src/validation/helpers.rs
11
50.94
-5.19% base_layer/core/src/base_node/sync/rpc/service.rs
8
77.26
1.04% comms/core/src/connectivity/manager.rs
6
81.82
-9.09% base_layer/common_types/src/types/fixed_hash.rs
6
87.14
-2.49% comms/core/src/protocol/rpc/status.rs
5
64.79
-1.48% base_layer/core/src/chain_storage/db_transaction.rs
5
73.08
-0.07% base_layer/wallet/src/output_manager_service/storage/sqlite_db/mod.rs
4
87.45
-0.4% base_layer/core/src/proof_of_work/cuckaroo_pow.rs
4
75.09
0.06% base_layer/wallet/src/transaction_service/storage/sqlite_db.rs
3
91.26
-0.46% comms/core/src/connection_manager/listener.rs
3
87.65
0.0% comms/core/src/protocol/messaging/inbound.rs
2
80.45
-0.21% comms/dht/src/connectivity/mod.rs
1
98.24
-0.15% base_layer/core/src/proof_of_work/monero_rx/merkle_tree.rs
1
78.72
0.0% base_layer/wallet/src/storage/sqlite_db/wallet.rs
Jobs
ID Job ID Ran Files Coverage
1 39587978986.1 814
76.45
GitHub Action Run
Source Files on build 39587978986