supabase / supabase-flutter / 39577048341

92%

push

github

fix(typegen): read built-in type names only from pg_catalog (#1990)

## Summary

The parser told types apart by name alone, which misread a user type
that shares a name with a built-in or extension type:

- A user type in another schema with a built-in's name was read as the
built-in. For example, a composite `public.money` got a `String` getter
and a composite `public.date` got a `PostgrestDate` getter. PostgREST
returns a composite as a JSON object, so reading the row failed with a
cast error.
- A composite named like an extension type, such as `public.vector`, was
read as pgvector.
- A type whose own name starts with an underscore, such as
`public._meta`, was read as an array.

Changes:

- Built-in names now only match when the column or function type lives
in `pg_catalog`. Every other type falls back to `Object?`, as an unknown
type does today.
- Extension types live in whichever schema the extension was created in,
so `vector`, `halfvec` and `citext` still match by name in any schema,
unless the type is a composite.
- Arrays come from the column's `data_type` and from the `[]` suffix of
a type's `format`, not from the leading underscore of its name.
- The bounds of a range come from its kind, so the schema rule lives in
one place.
- A type outside `pg_catalog` is named with its schema in the doc
comment of a function that has no method. The golden now reads
`title(public.books)`.

This comes before SDK-1930, which adds `point`, `line`, `path`, `box`
and `circle` to the text types. Those are common names for user
composite types.

## Tests

- A column of `public.name`, `public.money`, `public.int8`,
`public.date`, `public.json`, `public.bytea` and `public.tstzrange`
reads as unknown. An array `public._name` reads as an array of unknown
elements.
- Composites named `vector`, `citext` and `_meta` read as unknown and
not as arrays, for columns and function arguments.
- A function argument of type `public._money` and a result of type
`public.money` re... (continued)

29 of 29 new or added lines in 1 file covered. (100.0%)

10188 of 11074 relevant lines covered (92.0%)

5.5 hits per line