zwave-js / zwave-js-ui / 39569777473

18%

Build Type

push

github

Committed by web-flow

Commit Message

fix: review fixes (#4874)

Fixes from a review of the 14 PRs merged on 2026-10-20/21. There's one
commit per area so each can be checked on its own.

**CI on master:** every push workflow is green. The only failing
workflow is the weekly *Update bot-workflows* job. It fails because
`BOT_WORKFLOW_UPDATE_TOKEN` lacks permissions, which a code change can't
fix. Tracked in #4873.

### Fixes

| PR | Problem | Fix |
| --- | --- | --- |
| #4864 | PE653 `spa_thermostat` used `67-0-Furnace`, which doesn't
exist. Discovery threw and the entity was never created | Use
`67-0-setpoint-7` (Furnace). New test: every `default_setpoint` /
`setpoint_topic` must be a listed `67-<ep>-setpoint-<n>` value ID |
| #4863 | Gas meters have the same pulse-count bug. Gas scale 3 is
unitless, and HA rejects it with `device_class: gas` | No device class
for gas pulse count, plus tests |
| #4867 | `rgb_state_topic` and `color_temp_state_topic` share
`currentColor`, and HA keeps one topic's subscriptions in a `set`, so
the two handlers run in no fixed order. With the new template, a red
light was reported as `color_temp` at 4081 K. Also, HA does not clamp
`light.turn_on` to the color temp range: 6500 K sent `warmWhite: -92` |
Each value template renders only for its own mode: RGB when any RGB
channel is on, color temp when only the whites are on. An empty render
is ignored by HA. Each command template turns off the other mode's
channels, and the color temp command is clamped to 0–255. Advertises
`min_mireds: 245` / `max_mireds: 500` |
| (found while testing #4867) | RGB lights controlled by a Binary Switch
used `state_value_template: '{{ value_template.json }}'`, an undefined
variable. HA logged an error on every update and the state stayed
`unknown`. Broken on the release and master too | `{{ "ON" if
value_json.value \| string \| lower == "true" else "OFF" }}`. The string
compare also makes it work in RAW mode |
| #4869 | With *Retain discovery* off, the removal payload was not
ret... (continued)

Coverage Stats

723 of 4595 branches covered (15.73%)

Branch coverage included in aggregate %.

35 of 36 new or added lines in 6 files covered. (97.22%)

1 existing line in 1 file now uncovered.

1257 of 7086 relevant lines covered (17.74%)

2.57 hits per line