JuliaLang / julia / 1046

89%

Build Type

push

buildkite

Committed by web-flow

Commit Message

[JuliaLowering] Put minimal macro provenance in DebugInfo (#63963)

I originally planned to wait until we have AST provenance to do this properly,
    but it would be a bit of a regression to omit all macro frames, so add some.
    What is kept is noted in a comment:

```
The previous LineNumberNode-based system achieved a sane
amount of debuginfo by accidentally losing most of it (e.g. different
expansions but same provenance file name, or user-deleted line nodes, or lack
of macro-def line nodes).  Here, we have the problem that we need to omit some
information.  Only keep the pre-expansion provenance, as we always do, as well
as the latest-expansion provenance (if any) as a DebugInfo edge.
```

This means that we'll see some new frames (e.g. #44551 should be fixed) and lose
    some frames (intermediate expansions producing line nodes unlike the
    expansions around/within it) but I think this is an upgrade overall.

Also do a bit of extra searching for linenodes in some forms.

Coverage Stats

78 of 85 new or added lines in 3 files covered. (91.76%)

281 existing lines in 13 files now uncovered.

95397 of 107271 relevant lines covered (88.93%)

342.85 hits per line