IgniteUI / igniteui-angular / 39417914740

94%

push

github

fix(carousel): fix gesture, autoplay and aria issues, reach 100% coverage (#17767)

* fix(carousel): fix gesture, autoplay and aria issues, reach full coverage

- Keep existing slides' aria-labelledby in sync with the indicators
  when slides are added or removed
- Cancel the pending slides selection frame on destroy, so a carousel
  destroyed early no longer starts a leaking auto-play interval
- Restore the slides when a touch pan is cancelled (pointercancel)
- Clear the incoming slide after a pan ends, so a pan end without a
  matching pan no longer animates the current slide
- Do not leave the incoming slide visible when a short pan is reverted
  with animationType none
- Ignore pans on a carousel without slides instead of throwing
- Register/unregister touch gestures when gesturesSupport changes
  at runtime
- Default slide direction to NONE and reset it on the outgoing slide,
  so directly activated slides animate in the correct direction
- Unsubscribe from a slide's activeChange when it is removed
- Make stop() a no-op when not playing and auto-play only once on init
- Set aria-live to off only while the carousel is auto-rotating
- Use touch-action pan-x for vertical carousels
- Remove dead code, simplify template and interval handling
- Add tests reaching 100% statement/branch coverage for the carousel

* fix(carousel): clean up interrupted and reversed pans

- Cancel an in-progress pan when gesturesSupport is disabled
- Reset both slides when a pan reverses past a non-loop boundary
- Only restore/resume on pan cancel when a pan has actually started

* fix(carousel): sync playback state and handle slides removed mid-pan

- Mark for check when play()/stop() change the playback state, so
  aria-live updates for touch interactions under zoneless
- End the pan when all slides are removed before it ends
- Discard the incoming slide when it is removed during a pan

* fix(carousel): keep slide direction input and discard pans on removal

- Restore a s... (continued)

16165 of 17857 branches covered (90.52%)

Branch coverage included in aggregate %.

164 of 164 new or added lines in 2 files covered. (100.0%)

32230 of 33581 relevant lines covered (95.98%)

40135.65 hits per line