IgniteUI / igniteui-angular / 39275690717

94%

push

github

fix(dialog): mark view for check when open() is called programmatically (#17751)

* fix(dialog): mark view for check when open() is called programmatically

The igx-dialog--hidden host class is refreshed by the parent view, so
calling open() from an OnPush parent or an async callback left the
dialog hidden. IgxToggleDirective.open() only runs detectChanges() on
its own view, while the close path already calls markForCheck().

Add markForCheck() to IgxDialogComponent.open() and cover the parent
call and async callback cases in both zoneless and ZoneJS mode.

* chore(dialog): address review comments

- Remove the JSDoc from the test components.
- Replace the looped describe blocks with explicit ones.
- Drop the README section on programmatic opening.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Konstantin Dinev <kdinev@infragistics.com>

16109 of 17833 branches covered (90.33%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

32125 of 33507 relevant lines covered (95.88%)

40111.06 hits per line