supabase / supabase-swift / 39414026790

93%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(realtime): adopt WebSocketTransport in RealtimeClient and drop the legacy socket (#1600)

* refactor(realtime): adopt WebSocketTransport in RealtimeClient and drop the legacy socket

RealtimeClient now opens connections through the package `WebSocketTransport`
protocol. The `LegacyWebSocketTransport` closure typealias, the callback-style
`WebSocket` protocol, `LegacyWebSocketEvent`, and `URLSessionWebSocket` are
gone.

- The public initializer builds `URLSessionWebSocketTransport` from
  `options.session`'s configuration and delegate, as the old socket did.
- `push(_:)` and the broadcast pushes are `async` and await
  `WebSocketConnection.send` directly. Callers outside the actor already
  awaited them. A push queues behind frames still in `sendBuffer`, so it
  cannot overtake a flush after connect.
- `WebSocketConnection.close(code:reason:)` is synchronous: it only starts the
  close, and `.closed` reports completion. `deinit` can close the socket
  without a task.
- `disconnect()` with no code now sends 1000 (normal closure) instead of no
  status code.
- A connection that opens after its reconnect attempt was cancelled is now
  closed. It used to stay open.
- The RFC 6455 close-code and reason checks move from `URLSessionWebSocket`
  to `URLSessionWebSocketTransport`.
- `URLSession.sessionWithConfiguration` and `_Delegate` move unchanged to
  `Transport/URLSession+WebSocketDelegate.swift`.

Tests: the fakes conform to `WebSocketConnection`, and a test-only init keeps
the `wsTransport:` closure. The connect-failure, deallocation, session and
cert-pinning tests now run on `URLSessionWebSocketTransport`. Tests that only
covered the legacy event type, or repeated `URLSessionWebSocketTransportTests`,
are removed.

* fix(realtime): address review findings on the WebSocketTransport adoption

- A handshake that fails with `URLError.cancelled` (for example, a pinned
  certificate the delegate rejects) is now a retryable `.transport` error.
  Only a... (continued)

Coverage Stats

185 of 207 new or added lines in 6 files covered. (89.37%)

1 existing line in 1 file now uncovered.

12792 of 13768 relevant lines covered (92.91%)

887854.17 hits per line