supabase / supabase-swift / 39379320242

93%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(realtime): drive the client connection through a pure transition table (#1593)

* refactor(realtime): drive the client connection through a pure transition table

Move every connection state change into
`RealtimeClient.transition(_:_:)`, a pure function from (state, event) to
effects, and apply events in two phases: the table updates `connection`
first, then the effects run in order. An event raised while effects are
running is queued and reported with `reportIssue`, so the table always
sees one event at a time.

`connect()`, `disconnect()`, the socket reader, the heartbeat and the
reconnect loop now only raise events. The `connect()` attempt lives in
`connectAttempt`, outside the state, so `ConnectionState` is `Equatable`
and the table can be tested row by row without an actor, a clock or a
socket.

* fix(realtime): drop the outcome of a cancelled connect attempt

disconnect() cancels the connect attempt, but the transport call already in
flight keeps running and reported its outcome to the transition table once it
returned. The table has no attempt identity, so a stale failure moved a newer
attempt from .connecting to .disconnected, and a stale socket was installed in
place of the newer one. openSocket() now checks Task.isCancelled before it
applies either event and closes a socket that arrived too late.

* test(realtime): signal the second connect attempt instead of yield-looping

Tests/RealtimeTests forbids Task.yield loops; the gate registration now
yields on a stream the test awaits.

* test(realtime): wait for both connect attempts before releasing the stale one

The test waited only for attempt 1 to reach .connecting, which happens before its
transport call runs, so attempt 2 could arrive first and leave gate 1 unset. The
optional resume then did nothing and the test hung on the stale attempt. Wait for
both arrivals and require both gates.

* test(realtime): pin the stale connect attempt to transport call 1

Attempts are numbered by t... (continued)

Coverage Stats

198 of 212 new or added lines in 2 files covered. (93.4%)

12 existing lines in 2 files now uncovered.

13073 of 14123 relevant lines covered (92.57%)

26682.94 hits per line