Chia-Network / chia-blockchain / 39283186220

91%

Build Type

push

github

Committed by web-flow

Commit Message

Make timelord MMR test independent of fixture proof ordering (#21516)

## summary
- construct the stale-parent timing scenario instead of searching the
cached chain for an incidental nonzero-SP candidate
- use existing `skip_slots=2` and `force_overflow=True` block-generation
options; no generation monkeypatch or production changes
- preserve correct/stale MMR-root assertions and verify the parent was
infused before the candidate signage point

## verification
- all 5 `TestCommitments` tests passed on Python 3.13.12 / chia_rs
0.50.0
- in-memory stale-parent mutation fails at the final timelord MMR-root
assertion, as expected
- lint, formatting, diff checks, and commit hooks (including mypy)
passed
- used isolated regenerated block fixtures because the existing local
cache failed with `INVALID_SUB_EPOCH_SUMMARY`
- plot-group-specific dependencies and the full repository suite were
not tested locally

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Test-only change to block-commitment/timelord MMR coverage with no
runtime or consensus logic touched.
> 
> **Overview**
> **Refactors** `test_timelord_mmr_includes_peak_parent_before_sp` so
the stale-parent / nonzero-signage-point scenario is **built
deterministically** instead of discovered via `_late_parent_candidate`
on the cached fixture chain.
> 
> The test now picks a post-HF2, in-sub-slot parent from block records,
extends the chain with
`fork_height2_500_block_tools.get_consecutive_blocks` (`skip_slots=2`,
`force_overflow=True`), and uses the new tip as the candidate. It adds
checks that the candidate has a nonzero signage point and that the
parent was infused before the candidate’s SP. **Timelord MMR-root
expectations and the unfinished-block mutation are unchanged.**
> 
> No production code changes; `_late_parent_candidate` remains for other
tests.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
918a21fa0. Bugbot is set up for autom... (continued)

Coverage Stats

20011 of 25014 branches covered (80.0%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

87 existing lines in 25 files now uncovered.

117912 of 127798 relevant lines covered (92.26%)

1.85 hits per line