Chia-Network / chia-blockchain / 39258501453

90%

Build Type

push

github

Committed by web-flow

Commit Message

cap the batch size when creating block generators (#21418)

<!-- Merging Requirements:
- Please give your PR a title that is release-note friendly
- In order to be merged, you must add the most appropriate category
Label (Added, Changed, Fixed) to your PR
-->
<!-- Explain why this is an improvement (Does this add missing
functionality, improve performance, or reduce complexity?) -->

### Purpose:

feed the block builder/serializer smaller batches of work. In case it's
slow, we'll get stuck for a shorter time before checking the timeout.

### Current Behavior:

We maximize the batch

### New Behavior:

We submit the batch as soon as it exceeds 100 spends

<!-- As we aim for complete code coverage, please include details
regarding unit, and regression tests -->

### Testing Notes:

<!-- Attach any visual examples, or supporting evidence (attach any
.gif/video/console output below) -->


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes farming/block-assembly batching in a hot path; behavior under
timeout or very large items may differ, but consensus limits and
inclusion rules are unchanged.
> 
> **Overview**
> **Block generator creation** now flushes pending mempool transactions
to `BlockBuilder` in smaller chunks instead of growing one batch until
block cost is hit.
> 
> `create_block_generator2()` introduces **`MAX_SPENDS_PER_BATCH`
(100)** and commits the in-flight batch when adding the next item would
push **`batch_spends + len(unique_coin_spends)`** over that limit (in
addition to the existing max-block-cost flush). The goal is to bound
work per `add_spend_bundles()` call so the generation **timeout** can be
checked between batches. A single mempool item with more than 100 spends
is still submitted as **one** batch—it is not split.
> 
> A new unit test **`test_create_block_generator2_spend_batch_cap`**
monkeypatches `BlockBuilder.add_spend_bundles` and asserts batch sizes
`[50, MAX_SPENDS_PER_BATCH + 5]` for 50 single-spend items p... (continued)

Coverage Stats

20045 of 25014 branches covered (80.14%)

Branch coverage included in aggregate %.

25 of 25 new or added lines in 2 files covered. (100.0%)

21 existing lines in 8 files now uncovered.

117986 of 127793 relevant lines covered (92.33%)

1.85 hits per line