zalando / skipper / 39279299108

81%

Build Type

push

github

Committed by web-flow

Commit Message

fix(awssigner): initialize uri escape table once with sync.Once (#4343)

#### Problem
In `filters/awssigner/internal/uri.go`, `EscapePath()` invoked
`InitializeEscape()` on every execution to populate the package-level
`noEscape [256]bool` array. This caused:
- A data race when multiple goroutines execute `EscapePath()`
concurrently.
- Unnecessary CPU overhead by re-populating a static 256-element array
on every request.
- An unresolved `//TODO : is getting initialized every time` comment in
production code.

Additionally, `filters/awssigner/internal` had zero unit tests to verify
escaping rules or detect data races under concurrent execution.

#### Solution
- Wrapped the initialization inside `InitializeEscape()` with
`sync.Once` (`escapeOnce.Do(...)`). This preserves the existing function
signature while guaranteeing thread-safe, single execution across all
concurrent calls.
- Added `filters/awssigner/internal/uri_test.go`:
- Table-driven unit tests (`TestEscapePath`) covering unreserved
characters (`a-z`, `A-Z`, `0-9`, `-`, `.`, `_`, `~`), query characters,
special symbols, and separator encoding (`encodeSep=true/false`).
- Concurrent race test (`TestEscapePath_ConcurrentRace`) running
concurrent goroutines under race detection.

Signed-off-by: Shardool Patil <shardoolpatil999@gmail.com>

Coverage Stats

11 of 11 new or added lines in 1 file covered. (100.0%)

4 existing lines in 2 files now uncovered.

27730 of 34199 relevant lines covered (81.08%)

71869.83 hits per line