zalando / skipper / 39277283251

81%

Build Type

push

github

Committed by web-flow

Commit Message

fix(predicates/auth): clear predicateMap on cache clean to prevent memory leak (#4330)

### Description

Clears `registry.predicateMap` during the hourly ticker execution in
`registry.clean()`.

Previously, `registry.clean()` only iterated through existing entries to
call `p.cache.Clear()`, leaving `predicateMap` populated indefinitely.
This caused references to stale or removed route predicates to persist
in memory.

### Changes

- `predicates/auth/jwt.go`: Call `clear(r.predicateMap)` under `r.mu`
when the cleanup ticker fires. Active predicates are automatically
repopulated on the subsequent route update cycle.
- `predicates/auth/jwt_test.go`: Updated `TestPredicateCacheClean` to
assert that `reg.predicateMap` is emptied when the virtual timer
elapses.

### Related Issues and PRs
- Fixes #3609 
- #3600 introduced `predicateMap` to reuse compiled predicate instances
across route updates.

---------

Signed-off-by: Shardool Patil <shardoolpatil999@gmail.com>

Coverage Stats

22 of 25 new or added lines in 2 files covered. (88.0%)

1 existing line in 1 file now uncovered.

27717 of 34197 relevant lines covered (81.05%)

73146.33 hits per line