supabase / supabase-flutter / 39269728642

92%

Build Type

push

github

Committed by web-flow

Commit Message

feat(postgrest): retry typed calls of stable and immutable functions over GET (#1982)

## Summary

Typed function calls (`PostgrestRpc.rows` and `PostgrestRpc.value`,
which the methods `supabase_typegen` generates are built on) always sent
a POST. Automatic retry only applies to GET and HEAD, so
`client.rpc.searchBooks(query: 'dart').retry(count: 3)` never retried a
503, even for a read-only function.

### postgrest

- `rows` and `value` take `get`, the same option the untyped
`client.rpc(...)` has. With `get: true` the call is sent as a GET in
read-only access mode, with the arguments as query parameters, so it is
retried like a select.
- Arguments that are not a map are rejected with an `ArgumentError` when
the call is built, rather than when it is awaited.
- The request carries the flag as `PostgrestTableRequest.readOnly`, so
an executor other than the HTTP one can tell read-only calls apart
without knowing about GET.

### supabase_typegen

- Each `rpcFunctions` overload is joined to its `functions` entry
through `function_id` to read its `behavior`. No upstream change in
postgrest-typegen is needed. An overload without a matching entry counts
as volatile.
- A generated method passes `get: true` when its function is `STABLE` or
`IMMUTABLE` and every argument fits in a query parameter. Row arguments,
`json`/`jsonb` arguments, arrays of `json`, and the sole unnamed `json`
body keep the call on POST.

Regenerated code for stable functions therefore switches from POST to
GET, with `accept-profile` instead of `content-profile` for the schema.

There is no POST fallback for a query string that grows past a server's
URL limit, such as a very large array argument. supabase-js has none
either.

## Testing

- Unit tests for GET rendering, retry of read-only calls, no retry of
other calls, and the argument check.
- An integration test against the local stack that makes read-only
`rows` and `value` calls, one of them with an array argument.
- Parser test for v... (continued)

Coverage Stats

40 of 40 new or added lines in 5 files covered. (100.0%)

3 existing lines in 2 files now uncovered.

10166 of 11050 relevant lines covered (92.0%)

5.41 hits per line