supabase / supabase-flutter / 39266875227

92%

push

github

fix(storage): harden resumable upload failure, cancel and record handling (#1985)

Follow-up to #1984 (SDK-2276) with fixes from a review of the resumable
upload code. #1984 was merged before these commits were pushed.

## Fixes

- **A failed upload keeps its handle.** Once its retries run out, an
upload that still has a record stays registered as live.
`resumeUpload(id, file)` now returns that same `ResumableUpload` and
resumes it, as documented. Before, it built a second handle, and the two
could send `PATCH` requests to one upload URL at the same time.
- **A failing record store no longer hangs an upload.** If removing the
record throws inside the failure handler, the error is logged at warning
level. Before, `_run` threw: `done` never completed, the status stayed
`uploading`, and every later `resume()` was silently skipped.
- **Cancel loses to a completed upload.** `cancel()` now waits for the
in-flight request before deciding. If the response that completes the
upload is already in, the upload completes, `done` returns the stored
object, and no `DELETE` is sent. Before, `done` failed with
`ResumableUploadCancelledException` for an object that was already
stored. While a cancel is pending, `pause()` and `resume()` do nothing,
and calling `cancel()` again returns the same future.
- **Unreadable records are kept.** Each stored record is parsed on its
own. One the package cannot read, such as a record written by a newer
version, is skipped and written back unchanged. Before, it dropped every
record after it, and the next save deleted them for good.
- **Signed uploads stay unauthenticated after a restart.**
`resumeUpload`, `resumeUploadBinary` and `discardResumableUpload` no
longer send the client's headers for a record that holds a signed upload
token, which matches how the upload was started.
- **One project ref derivation.** The record key and the session key
both come from a new `projectRef` helper in `supabase_common`.
- **Docs:** `fileOptions.he... (continued)

33 of 36 new or added lines in 3 files covered. (91.67%)

10084 of 10966 relevant lines covered (91.96%)

5.42 hits per line