• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stillwater-sc / universal / 39090880833
89%
master: 84%

Build:
Build:
LAST BUILD BRANCH: fix/issue-2128-lns-correct-rounding
DEFAULT BRANCH: master
Ran 18 Oct 2026 02:56AM UTC
Jobs 1
Files 749
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

18 Oct 2026 02:39AM UTC coverage: 87.149% (+0.3%) from 86.877%
39090880833

push

github

web-flow
refactor(math): remove the multi-double NATIVE_SQRT and NATIVE_TRIGONOMETRY switches (#1726)

dd, qd, dd_cascade, td_cascade and qd_cascade chose between their native,
full-precision sqrt (and, for qd, trigonometry) and a shim that converted
to double and called std::. The shims were scaffolding from before the
native algorithms existed (#426, #437, #443, #487). Setting a switch to 0
silently gave a 106-, 159- or 212-bit type double precision. #1667 removed
the HYPERBOLIC and MINMAX siblings for the same reason. Now the native
code is unconditional, and the umbrellas carry a note in place of the
defaults.

The switches were also a live bug. Only the umbrella qd.hpp set
QUADDOUBLE_NATIVE_SQRT and QUADDOUBLE_NATIVE_TRIGONOMETRY to 1.
qd/math/functions/sqrt.hpp defaulted the first to 0 itself, and in
`#if !QUADDOUBLE_NATIVE_TRIGONOMETRY` the undefined macro evaluates to 0.
A translation unit on the layered path of #1334 (core, attributes,
constants, mathlib, without qd.hpp) therefore got both shims:
sqrt(2)^2 - 2 = 2.7e-16 and sin(1) with zero trailing limbs, against
-1.2e-66 through the umbrella. That path had no qd sincos at all.

The native qd sqrt was also a non-inline function defined in a header
(an ODR violation across translation units); it is inline now. sec, csc
and cot existed only in the qd shim, never in the default build or in
any other multi-double type, and go with it.

static/highprecision/<type>/math/core_path.cpp includes each type's
headers without the umbrella. verification/multidouble_core_path.hpp
checks that sqrt, sin, cos, sincos, tan and the inverses hold the
type's precision there, every residual within 2^-(p-8). On main the qd
test does not compile (no sincos on that path).

The core-path trigonometry is also pinned against mpmath values (sin, cos,
sincos and atan at 2.5, sqrt(2)), so a sincos that negates both outputs
fails; the identity checks alone would accept it.

Resolves #1724

BEHAVIOUR-CHANGE: qd sqrt and trigonometry... (continued)

38 of 40 new or added lines in 2 files covered. (95.0%)

50746 of 58229 relevant lines covered (87.15%)

10282223.31 hits per line

Uncovered Changes

Lines Coverage ∆ File
2
94.87
include/sw/universal/verification/multidouble_core_path.hpp
Jobs
ID Job ID Ran Files Coverage
1 39090880833.1 18 Oct 2026 02:56AM UTC 749
87.15
GitHub Action Run
Source Files on build 39090880833
  • Tree
  • List 749
  • Changed 9
  • Source Changed 6
  • Coverage Changed 9
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #39090880833
  • 15da1393 on github
  • Prev Build on main (#39087829795)
  • Next Build on main (#39093502751)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc