iotaledger / iota / 39086071940

72%

Build Type

push

github

Committed by web-flow

Commit Message

fix(iota-storage): check summary sequence numbers, evict rejected entries (#13017)

# Description of change

Two `HttpKVStore` gaps that the gRPC fallback (next PR) hits; the first
also affects JSON-RPC.

- Check the sequence number of summaries read by sequence number, like
the by-digest path already does; a summary for another checkpoint is now
a miss instead of being served. Checkpoint summaries and contents it
rejects in `multi_get_checkpoints` are dropped from the cache, so a
fixed entry is read again.
- Add `evict_objects` / `evict_events_by_tx_digests` to
`TransactionKeyValueStoreTrait` (no-op defaults). `HttpKVStore` drops
the cached entry, so data a reader rejects is fetched again instead of
failing until the cache entry idles out.

Not changed here: contents read by sequence number are still not checked
against the summary, and the other reads (transactions, effects,
objects, events, transaction-to-checkpoint) still keep an entry they
reject cached, as on `develop`. The store is trusted: the checks catch
data under the wrong key, not forged data.

## Links to any relevant issues

Part of #12801

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

New simtests in `iota-storage`: a summary for another sequence number is
a miss; an evicted object is fetched again.

Coverage Stats

0 of 48 new or added lines in 3 files covered. (0.0%)

91 existing lines in 15 files now uncovered.

188321 of 266249 relevant lines covered (70.73%)

447555.66 hits per line