decentraland / sites / 38960278104

94%

push

github

feat: send navbar clicks made before analytics loads through the beacon (#909)

* feat: send navbar clicks made before analytics loads through the beacon

* fix: queue navbar clicks that keep the page instead of beaconing them

* feat: flag beacon-sent navbar clicks as deferred

* feat: send the deferral timestamps with beacon navbar clicks

* fix: treat alt-clicks on navbar links as keeping the page

* refactor: share the deferred click beacon between the navbar and download CTAs

* refactor: name the leavesPage option on navbar tracking calls

* test: cover Sign In, section tab and Jump In clicks before analytics loads

* refactor: type isSameTabNavigation's event as a pick of the React mouse event

* docs: say the isInitialized ref keeps the click handlers stable

* docs: say which gates each postDeferredClick caller applies

* test: cover pre-ready middle and modifier clicks and the no-double-send case

* fix: skip the deferred queue for exempt sessions and bots too

* test: assert the queued Jump In click is sent exactly once

* fix: treat named link targets as opening elsewhere

* test: restore window.scrollY after each navbar test

* test: drop async from navbar setup blocks that await nothing

* refactor: move the navbar click link and options types to LandingNavbar.types

* test: share the gate cases and the analytics-ready rerender across navbar tests

* fix: resolve the beacon's anonymous id only after the write key check

* docs: explain why the beacon skips the exempt-path gate now that the navbar uses it

* test: stop expecting the store-exit beacon to receive an anonymous id

* fix: treat navbar links with a download attribute as keeping the page

* test: cover a navbar link with an empty target

* refactor: gate non-conversion deferred clicks for exempt sessions and bots in one place

* test: explain why the store-exit spec still mocks the anonymous id module

* docs: name the visitor gate non-conversion beacon callers apply

* docs: d... (continued)

6288 of 7212 branches covered (87.19%)

Branch coverage included in aggregate %.

38 of 38 new or added lines in 6 files covered. (100.0%)

15089 of 15478 relevant lines covered (97.49%)

26.14 hits per line