kobotoolbox / kpi / 38914364267

83%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

feat(enketo): use internal enketo URL DEV-3063 (#7690)

### 👷 Description for instance maintainers
Updates kpi to communicate with enketo using internal enketo's URL's,
and provides kobocat's internal URLs to enketo to use in turn (via
redis).

### 💭 Notes
Update kpi to use internal URLs for communication between enketo and
kpi. POST requests from kpi -> enketo now go through the internal enketo
URL, although we still return the external links in the serializer.
Similarly, we now store the internal kpi/kobocat url in redis rather
than the external, so enketo will use these urls when getting
information from the server. This allows for faster and more reliable
communication between kpi and enketo.

The url for each asset will only be updated to use the internal url
once. Once we have done that, we set a flag on the asset noting that the
internal url is already stored and we don't need to update it in redis
again (except for pre-existing cases like when `require_auth` changes or
permissions are changed).

Right now it's behind a constance setting so we can easily turn it off
if something goes wrong. We expect to eventually remove the setting and
have it be standard on all instances.

This PR also introduces a small performance gain: enketo ids (and the
encoded versions) are static throughout the lifetime of the asset, and
we know the structure of the links enketo creates. Therefore, once we've
fetched the enketo response once, we have all the information needed to
generate all the enketo links locally without having to make a round
trip to enketo again.


### 👀 Preview steps
Regression test only. Ensure that deploying surveys, transferring
ownership, using data collectors, etc. works as expected when
`ENKETO_USE_INTERNAL_OPENROSA_URL` is True in Constance.

---------

Co-authored-by: Olivier Léger <olivierleger@gmail.com>

Coverage Stats

10415 of 13731 branches covered (75.85%)

62 of 151 new or added lines in 12 files covered. (41.06%)

6511 existing lines in 170 files now uncovered.

33265 of 39988 relevant lines covered (83.19%)

5.51 hits per line