elixir-mint / mint / 96bc2b50a692679ca4ff8c14aa280254ad38d6c8-PR-525

90%

main: 91%

Build Type

Pull #525

github

Committed by ericmj

Commit Message

Accept transfer codings with parameters in Transfer-Encoding

A Transfer-Encoding value with a parameter, such as
"custom; level=1, chunked", failed with {:invalid_token_list, value}
because the value was parsed as a plain list of tokens. RFC 9110 10.1.4
allows parameters on a transfer coding, as a token or a quoted string.

Transfer-Encoding values are now parsed with their parameters and only
the coding names are kept, so the final coding of a response still
decides between chunked framing and reading until close. The chunked
coding defines no parameters and RFC 9112 7.1 says their presence
should be treated as an error, so chunked with parameters is still
rejected.

The same parser checks the Transfer-Encoding headers passed to request/5
with a streamed body and no Content-Length, so a value such as
"gzip;q=1" is accepted there. The fields are combined with ", " into
one value before parsing (RFC 9110 5.3). If chunked or identity is among
the codings the headers are sent unchanged, as before. Otherwise chunked
is appended to the last field, so it ends up as the final coding once.

Pull Request Pull Request #525: Accept transfer codings with parameters in Transfer-Encoding

Coverage Stats

39 of 39 new or added lines in 2 files covered. (100.0%)

6 existing lines in 3 files now uncovered.

1811 of 2002 relevant lines covered (90.46%)

708.15 hits per line