solidjs / solid / 38849483716

78%

main: 89%

push

github

feat(diagnostics): source locations on every finding, docs page per code (#4107)

* feat(diagnostics): carry a source location on every finding

Dev and observe builds keep a `loc` (`file:line:col`, root-relative — the
compiler's `sourceNames` `locations` kind) in a `_loc` slot beside `_name`
on owner, computed, effect, signal and store-property nodes, and on the
client and server component owners through a fourth `createComponent`
argument. `emitDiagnostic` resolves `DiagnosticEvent.loc` as the innermost
located node on the subject's chain, the way `ownerPath` is found, and
`reportDiagnostic` prints it as an `at` line after `in` — a dev-server URL in
a browser so the devtools link it to Sources. `@solidjs/web`'s `effect` and
`insert` take `loc` in their options, `spread` a trailing `loc`.

`DEV.guideUrl(code)` is now the code's docs page
(`https://v2.solidjs.com/reference/solid-js/diagnostics/<slug>`); the console
footer leads with it for a human and keeps the repair skill (installed path
and GitHub anchor) on a second line for an agent. `diagnostics.json` is
regenerated and the skill documents the `at` line.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ka6h98478umeFadcRV1KLY

* feat(babel-plugin): sourceNames.locations carries file:line:col

A third `sourceNames` kind, `locations`, and a `root` option. Where a
component or binding label is emitted, its source location rides beside it:
`createComponent(Home, props, "Home", "src/App.tsx:12:5")` (the `<Home`
opening element, DOM and SSR), `{ name: "div.class", loc: "src/App.tsx:14:7" }`
(the attribute start; a merged effect points at its first attribute), a
hole's `{` for its insert, and the first spread attribute's start as one more
`spread` argument after the tag. The path is relative to `root` (default:
Babel's `cwd`), posix separators, line and column 1-based. `locations`
follows `dev` like the other kinds; no `filename` → no location.

... (continued)

751 of 1042 branches covered (72.07%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 3 files covered. (100.0%)

1089 of 1331 relevant lines covered (81.82%)

27.98 hits per line