iotaledger / iota / 38834179396

72%

Build Type

push

github

Committed by web-flow

Commit Message

fix(iota-types,iota-core): include the signature in the authority-capabilities cache key (#13199)

# Description of change

- The signature verifier caches successful checks of signed authority
capability notifications, keyed on the capabilities data and the epoch
only.
- A notification with the same data but a different signature therefore
hit the cache and was accepted without its own signature being checked.
- The cache key now also covers the signature, matching how the
certificate cache already keys on the full signed certificate.
- The cache is in memory only, so no migration is needed.

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

Added `test_authority_capabilities_cache_hit_still_checks_signature`:
after a verifier accepts a notification, a copy with the same data and a
signature from another key must still be rejected. It fails without the
fix and passes with it.

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

1428 existing lines in 45 files now uncovered.

187975 of 265922 relevant lines covered (70.69%)

442438.7 hits per line