accordproject / concerto / 38779219420

98%

push

github

fix(concerto-core): fully type check map keys and values (#1568)

ResourceValidator.checkMapType skipped numeric types (Integer, Long,
Double), unwrapped scalar values only when the key was a scalar,
ignored scalar validators, accepted booleans and numbers for DateTime,
and searched only the local model file instead of resolving imports.

- Resolve slot type via modelManager.getType and modelFile.getFullyQualifiedTypeName
- Unwrap scalar slot being checked and execute scalar validator
- Add Integer, Long, and Double type validation cases
- Strictly validate DateTime values against booleans and numbers
- Add unit tests covering map key/value type validation

Closes #1560

Signed-off-by: Tushar Singh <tusharsingh222555@gmail.com>

2385 of 2499 branches covered (95.44%)

Branch coverage included in aggregate %.

21 of 21 new or added lines in 1 file covered. (100.0%)

4263 of 4305 relevant lines covered (99.02%)

126642.0 hits per line