accordproject / concerto / 38764214038

98%

push

github

fix(concerto-core): treat relationship-typed map values as relationships (#1567)

* fix(concerto-core): treat relationship-typed map values as relationships

Relationship-typed map values (map M { o String --> P }) were previously
treated as embedded objects rather than relationships across the serializer,
causing fromJSON to reject relationship references/URIs, toJSON to serialize
them as embedded objects, and validation to ignore relationship semantics.

- Add isRelationship, getName, and getFullyQualifiedTypeName to MapValueType
- Validate in MapValueType that relationship targets are identified classes
- Extract processRelationship in JSONPopulator to read relationship map values as Relationships
- Extract processRelationship in JSONGenerator to serialize relationship map values as URIs
- Update checkMapType in ResourceValidator to validate relationship map values via checkRelationship
- Add comprehensive tests for relationship map serialization, deserialization, and introspection

Closes #1563

Signed-off-by: Tushar Singh <tusharsingh222555@gmail.com>

* fix(concerto-core): reject unresolved map value types during validation

Reject unresolved non-primitive map value declarations before checking
whether the declaration is a map or identified type in MapValueType.validate().
Adds unit test coverage verifying IllegalModelException is thrown when
relationship or object map values point to missing types.

Signed-off-by: Tushar Singh <tusharsingh222555@gmail.com>

* test(concerto-core): remove unrelated tests from resourcevalidator

Signed-off-by: Tushar Singh <tusharsingh222555@gmail.com>

* fix(concerto-core): scope map value missing-type validation to relationships

Signed-off-by: Tushar Singh <tusharsingh222555@gmail.com>

---------

Signed-off-by: Tushar Singh <tusharsingh222555@gmail.com>

2366 of 2478 branches covered (95.48%)

Branch coverage included in aggregate %.

61 of 62 new or added lines in 5 files covered. (98.39%)

4252 of 4294 relevant lines covered (99.02%)

126021.99 hits per line