supabase / storage / 38744448797

86%

push

github

test: extensive acceptance coverage for object versioning (#1425)

## Summary

Rebased onto `master` now that #1347 is merged, so this PR is a single
commit containing only the acceptance coverage.

- Adds `acceptance/specs/rest-object-versioning.test.ts`: 26 black-box
acceptance tests covering bucket versioning status transitions,
per-version upload history, SUSPENDED-era mutable-slot semantics, delete
markers/undelete, single and bulk delete (including hard-delete by
`versionId` with promotion of the previous version), copy/move under
versioning, and concurrency races.
- All database-state assertions go through the REST surface only
(`/object/info/...`, `/object/list-v2/...` with
`noncurrentVersions`/`deleteMarkers`), consistent with the acceptance
suite's black-box design.
- Adds a gated `versioning` acceptance capability
(`ACCEPTANCE_ENABLE_VERSIONING`) plus a `versioningStatus` option on
`createRestBucket`, and documents both in the README/API coverage doc
and `.env.acceptance.sample`.
- Plumbs `ACCEPTANCE_ENABLE_VERSIONING` into the remote acceptance job
the same way every other gated capability is, so it can be turned on for
remote targets via a repo variable.

The local CI legs pick the capability up automatically: they copy
`.env.acceptance.sample` (now sets `ACCEPTANCE_ENABLE_VERSIONING=true`)
and `.env.test.sample` (already sets `STORAGE_VERSIONING_ENABLED=true`),
and in multitenant mode the app-level flag short-circuits the per-tenant
`objectVersioning` check — so the spec really runs on all 18 local legs
rather than silently skipping.

### Review feedback addressed

- The documented "disable-after-enable rejection" contract is now
actually tested, from both `ENABLED` and `SUSPENDED`. Worth noting what
it turned out to be: `PUT /bucket/:id` does not accept `DISABLED` at all
(`updateBucket`'s schema enum is `['ENABLED', 'SUSPENDED']`), so the
request is refused by validation before `updateBucket`'s transition rule
in `src/storage/database/p... (continued)

7698 of 9483 branches covered (81.18%)

Branch coverage included in aggregate %.

13362 of 15086 relevant lines covered (88.57%)

861.12 hits per line