supabase / storage / 38731867030

86%

push

github

fix: retry file backend writes when delete cleanup removes the parent directory (#1515)

## What kind of change does this PR introduce?

Bug fix.

## What is the current behavior?

In the file backend, `ensureFile` creates the parent folders and then
the file. A concurrent delete can run `cleanupEmptyDirectories` between
these steps and remove the new, still-empty folders. The upload then
fails with a 500: `ENOENT: no such file or directory, mkdir
'<root>/stub/stub'` (or `open ...`). Closes #1514.

## What is the new behavior?

`ensureFile` retries `mkdir` and `open` on ENOENT, up to 5 attempts.
When `open` succeeds, the file is in the folder, and the cleanup's
`rmdir` fails on a non-empty folder (#1301). All `ensureFile` callers
get the fix: `uploadObject`, `copyObject` and the TUS `FileStore`.

## Additional context

- New unit test in `file.test.ts`: it runs the empty-folder cleanup
right after `mkdir` and checks that the upload still succeeds. It fails
on `master` with `ENOENT ... open` and passes with this change.
- Stress check (not committed): 4 parallel upload/delete loops, 1200
uploads per run. `master`: 8 to 52 failures per run. With this change: 0
failures in 5 runs.
- `biome check`, `prettier --check` and `tsc --noEmit` pass.
- Related to #1301

---------

Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>
Co-authored-by: Ferhat Elmas <elmas.ferhat@gmail.com>

7698 of 9483 branches covered (81.18%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 2 files covered. (100.0%)

13362 of 15086 relevant lines covered (88.57%)

861.11 hits per line