decentraland / comms-gatekeeper / 38741026709

89%

Build Type

push

github

Committed by web-flow

Commit Message

feat: let the presentation bot update its metadata and fix presenter and world notification place lookups (#303)

* chore: Add .plan-plus.json file

* feat: let the presentation bot update its own metadata

* style: apply prettier to files that failed format:check

Also removes the explanatory comment in src/index.ts.

* fix: resolve full places for presenter checks and world notifications

The Places /places/status response carries no parcel positions, but the
presenter admin check and the cron-driven notifications treated it as a
full place. Presenter endpoints crashed with a 500 for every Genesis City
scene, and world notifications silently widened to every allow-listed
wallet in the world.

- Add places.getPlaceById (cached GET /places/:id) and use it for the
  presenter admin check, bound to the stream access place.
- Resolve missing positions in getAdminsAndExtraAddresses before the
  allow-list fallback, so a failed lookup propagates instead of widening
  recipients, and fetch world permissions once.
- Type the status response as PlaceStatus (no positions) so the compiler
  rejects callers that rely on them.
- Document the 404 on the presenter endpoints, fix stale JSDoc and test
  names, and cover the watcher token keeping canUpdateOwnMetadata false.

Also documents:
- AGENTS.md: integration tests need docker-compose Postgres on 5450

* fix: report only a Places 404 as a missing place

getPlaceById turned every fetch failure into PlaceNotFoundError, so a
Places outage made the presenter endpoints answer 404 "the stream's place
no longer exists" instead of a 5xx.

The cached fetch now throws an HttpStatusError carrying the response
status, and getPlaceById maps only a 404 to PlaceNotFoundError; 5xx and
transport failures propagate unchanged.

* style: format merged Places status type

* test: reconcile presenter and cleanup fixtures with full-place lookup

---------

Co-authored-by: LautaroPetaccio <lausuper@gmail.com>

Coverage Stats

1729 of 2049 branches covered (84.38%)

Branch coverage included in aggregate %.

31 of 36 new or added lines in 7 files covered. (86.11%)

2 existing lines in 2 files now uncovered.

4007 of 4355 relevant lines covered (92.01%)

97.47 hits per line