urwid / urwid / 38731807928

91%

push

github

Fix FloatEdit exponent defaults and long-value quantization (#1447)

FloatEdit mishandled three default-value paths:

- A default in exponent notation ('1e5' or Decimal('1E+5')) was shown
  verbatim in the edit field, whose allowed characters are digits and
  the decimal separator only, so the displayed text could not be edited
  or re-parsed. Format finite Decimal defaults with fixed-point
  notation instead of str(), which switches to exponent form.
- Non-finite defaults ('inf', 'nan', Decimal('Infinity')) were
  accepted and rendered as text the widget rejects on edit. Reject
  them up front with a ValueError.
- With preserve_significance=True, quantizing a long entered value to
  the default's significance raised decimal.InvalidOperation once the
  result coefficient exceeded the active context precision (28).
  Compute the required precision from both operands and quantize
  inside a localcontext wide enough for it.

Regression tests cover all three paths.

Signed-off-by: Charan Rathore <180254320+charan-rathore@users.noreply.github.com>

4931 of 5692 branches covered (86.63%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 1 file covered. (100.0%)

12340 of 13599 relevant lines covered (90.74%)

14.31 hits per line