solidjs / solid / 38707922491

78%

main: 89%

push

github

fix(signals): a held error waits for its frame (D-41) (#4085)

* proto(signals): stage errors like values, publish at the commit (D-40)

Prototype for the proposed D-40: an error a held pass finds is staged in
_pendingValue (CONFIG_STAGED_ERROR), propagated to dependents as a staging
of their own, and published by commitPendingNode when the frame lands. A
held recovery keeps the shown error until its landing; a re-ask of the
source whose error a node shows re-runs it on the settle.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015Q7JD9PktsxtBJJbWmtuwr

* docs(signals): D-40, an error is an answer — proposed rule, scenarios and pins

An error settles the async its node asked for, so a hold never waits on
it; but settled is not shown. A value landing on a held node is staged
until the frame reveals, an error publishes at once. F-1 and F-2 already
decide this; D-40 states it as a narrowing of F-12, S-41/S-42 are the
screens, Q-6 puts the two columns to the maintainer, Q-7 the loadingValue
contract question #3886 raised beside it. Pinned it.fails.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015Q7JD9PktsxtBJJbWmtuwr

* docs(signals): Q-6 — what D-40 costs (prototype); pins unwrap the status error

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015Q7JD9PktsxtBJJbWmtuwr

* fix(signals): a held error waits for its frame (D-41)

An error a held node's flight or pass finds is staged like a value and
published by the frame's commit through the ordinary error path; the
separate staged-error publish path is gone. A held recovery keeps the
shown error until its own commit, a recovery equal to the last good value
reaches effects, latest() throws a staged error (born held too), and
watch() (resolve/until/refresh) rejects at the landing.

Rules: D-40 (#3995, proposed) renumbered D-41 and ruled ... (continued)

755 of 1046 branches covered (72.18%)

Branch coverage included in aggregate %.

1086 of 1328 relevant lines covered (81.78%)

27.81 hits per line