solidjs / solid / 38701988770

78%

main: 89%

push

github

fix(babel-plugin,compiler): SSR evaluates a ref factory beside a spread and under serverComponents (#4081) (#4090)

* fix(babel-plugin,compiler): SSR evaluates a ref factory beside a spread (#4081)

The template path evaluates an element's ref expression on the server
(`_ref$ = expr`) without calling the ref, so a ref factory's owned setup runs
on both sides. Beside a spread both compilers dropped the expression: the
setup's primitive was created on the client only and every hydration id
after it shifted. The spread path now evaluates a ref that calls something
in ssrElement's attrs thunk, after the spread and the tail markup and before
the children, where the client evaluates it.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fTNh1FgQx2WTF5xoxwML1

* fix(babel-plugin,compiler): run ref factories outside server component renders (#4081)

Under `serverComponents` a ref expression was only a claim, evaluated by
`ssrClaim` inside a server component's render. A whole SSR build compiles
that way, so a hydrating element outside one never ran its ref factory's
owned setup on either path, and the hydration ids after it shifted. The
template hole's unarmed branch now evaluates a ref that calls something,
and a spread element's attrs thunk evaluates it behind
`ctx && ctx.claims ||`, so it runs exactly once in either render.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fTNh1FgQx2WTF5xoxwML1

---------

Co-authored-by: Claude <noreply@anthropic.com>

755 of 1046 branches covered (72.18%)

Branch coverage included in aggregate %.

1086 of 1328 relevant lines covered (81.78%)

27.58 hits per line