pantsbuild / pants / 38640865803
93%

DEFAULT BRANCH: main
Ran
Jobs 11
Files 1785
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 92.951% (+0.009%) from 92.942%
38640865803

push

github

web-flow 
Support hierarchical mypy config discovery (#23633)

* Adds support for mypy's standard config discovery, as described
[here](https://mypy.readthedocs.io/en/stable/config_file.html), and
quoted below.
> If true, Pants will include any relevant config files during runs
(mypy.ini, .mypy.ini, and setup.cfg).
Use [mypy].config instead if your config is in a non-standard location.

* Specifically, this adjusts the behavior when `[mypy].config_discovery
= true` such that mypy configuration discovery uses the nearest ancestor
mypy config discovered for the source(s) a `check` goal runs against.
* Prior to this feature, the `[mypy].config_discovery = true` would
exclusively search for a mypy config file in the repo root, while
ignoring any + all other mypy configs.
* This changes does NOT modify the behavior when `[mypy].config =
"<path-to-config-file>"`, which remains mutually exclusive with
`[mypy].config_discovery`.

## Why?
* The current `[mypy].config_discovery` option is not consistent with
how mypy's "standard" discovery works.
* A single mypy config for a multi-resolve monorepo can lead to
problems, since not all mypy config options are scope-able to a
particular module override (basically any config option noted as living
in the `[global]` section of a mypy config).
* example: the [plugins
option](https://mypy.readthedocs.io/en/stable/config_file.html#confval-plugins).

## Relevant Issue(s)
closes https://github.com/pantsbuild/pants/issues/23533

## LLM Assistance Disclosure
I primarily used Claude Code (Opus 5, extra high effort) for the
implementation of this feature once I wrote the initial mypy
partitioning component, with manual adjustment of most of the test
cases, and manual removal of claude comments.

96423 of 103735 relevant lines covered (92.95%)

3.66 hits per line

Coverage Regressions

Lines Coverage ∆ File
8
93.1
0.38% src/python/pants/backend/python/typecheck/mypy/subsystem.py
2
98.71
0.32% src/python/pants/backend/python/typecheck/mypy/rules.py
Jobs
ID Job ID Ran Files Coverage
1 test_python_linux_x86_64_4/10 - 38640865803.1 1246
59.02
GitHub Action Run
2 test_python_linux_x86_64_7/10 - 38640865803.2 1220
50.85
GitHub Action Run
3 test_python_linux_arm64 - 38640865803.3 1197
52.6
GitHub Action Run
4 test_python_linux_x86_64_2/10 - 38640865803.4 1216
58.48
GitHub Action Run
5 test_python_linux_x86_64_3/10 - 38640865803.5 1215
52.27
GitHub Action Run
6 test_python_linux_x86_64_9/10 - 38640865803.6 1226
53.95
GitHub Action Run
7 test_python_linux_x86_64_5/10 - 38640865803.7 1232
60.31
GitHub Action Run
8 test_python_linux_x86_64_1/10 - 38640865803.8 1216
48.83
GitHub Action Run
9 test_python_linux_x86_64_8/10 - 38640865803.9 1215
52.64
GitHub Action Run
10 test_python_linux_x86_64_0/10 - 38640865803.10 1237
57.36
GitHub Action Run
11 test_python_linux_x86_64_6/10 - 38640865803.11 1213
50.08
GitHub Action Run
Source Files on build 38640865803