mindersec / minder / 38629092471

65%

push

github

fix(cli): route structured output to stdout across commands (#6879) (#6883)

* fix(cli): route structured output to stdout across commands (#6879)

Cobra commands write to OutOrStderr by default when cmd.Println or
cmd.Print is called without explicit stdout configuration on RootCmd.
This caused JSON and YAML output across multiple commands to be routed
to stderr rather than stdout, breaking shell pipelines such as
'minder project list -o json | jq .'.

This change fixes the issue by:
1. Setting RootCmd.SetOut(os.Stdout) in root command init so Cobra defaults
   all command output streams to stdout.
2. Introducing reusable cli.PrintProto and cli.PrintMultiProtoYAML helpers
   in internal/util/cli that write formatted JSON/YAML directly to
   cmd.OutOrStdout().
3. Refactoring subcommands across artifact, datasource, entity, history,
   profile, project, provider, repo, and ruletype packages to use
   cli.PrintProto.
4. Adding unit test coverage for PrintProto and PrintMultiProtoYAML.

Fixes #6879

* fix(cli): address review feedback on stdout routing

- Drop RootCmd.SetOut(os.Stdout) to avoid changing default stream
  for non-converted call sites.
- Wrap long lines in role_grant.go and role_update.go to stay
  under 130-character limit.
- Document PrintProto format string matching avoiding import cycle.

27 of 33 new or added lines in 2 files covered. (81.82%)

22630 of 35345 relevant lines covered (64.03%)

53.3 hits per line