thoughtspot / mcp-server / 38628417174

91%

push

github

Integrate SpotterViz in TS MCP Server (#159)

* Implement SpotterViz tools (rebased on main)

Replaces prior spotterviz-integration history with a single commit
generated from spotterviz-rebased-on-main.patch.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Remove the deprecated spotterviz_* tools; guard null Aurora/save bodies

Review feedback on #159: the four low-level SpotterViz session tools were
kept hidden-but-dispatchable "for existing callers", but they were never on
main, so there are no such callers. Removed outright:
spotterviz_create_session, spotterviz_submit_query, spotterviz_get_updates
and spotterviz_save_liveboard, with their schemas, tool definitions,
dispatch cases, handlers, and the hidden-tools filter.

The SpotterViz service, client and SSE handling stay: create_dashboard,
modify_dashboard and get_dashboard_status are built on them.

Also addresses the remaining gemini-code-assist comments that were still
open:
- createAuroraSession: a null or non-object /aurora/init body crashed with
  an opaque TypeError on data.success. Now throws a clear error.
- saveBachPinboard: a null body skipped the status check and returned as a
  successful save. Since the save is what commits the edit session to the
  saved liveboard, that silently lost the user's changes. Now throws.
- createBachPinboardSession was already safe: a null body throws "missing
  session ids in response".

Both new tests were checked to fail without their guards.

Verified: 1,002 tests pass, biome lint and format clean, tsc reports the
same 18 errors as main with none new.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* Bound every dashboard tool call; address PR review

Stability (dashboard tools hung for minutes in Claude Desktop):
- Each task runs as one background job (setup, Aurora stream, save,
  stored outcome). create/modify wait at most 50s, then return
  in_progress with a task id minted up front.
- get_dashboard_status only reads stored ... (continued)

1684 of 1918 branches covered (87.8%)

Branch coverage included in aggregate %.

562 of 588 new or added lines in 14 files covered. (95.58%)

2883 of 3103 relevant lines covered (92.91%)

1680.8 hits per line