dart-lang / tools / 38614082104

96%

push

github

[markdown] Fix LinkParser edge cases and BlockParser retreat loop (#2631)

Fix crashes and misparses on malformed link reference definitions, retreating block syntaxes, and list-ending footnotes:

- Guard against EOF after trailing `\` or `<` in `LinkParser`, and require balanced parentheses across bare link destinations (`[a]: /url(a)b`).
- Track all retreating `BlockSyntax` rules per line (`List<BlockSyntax>`) in `BlockParser.parseLines` so two retreating syntaxes on the same line cannot loop.
- Type `Element.children` as `List<Node>` in list/table/footnote builders so appending footnote backreferences (`List<Node>`) to a footnote ending in a list does not throw `TypeError`.

22 of 22 new or added lines in 7 files covered. (100.0%)

1634 of 1710 relevant lines covered (95.56%)

4.17 hits per line