dart-lang / tools

94%

LAST BUILD ON BRANCH main

branch: SELECT

CHANGE BRANCH

x

Sync Branches

• No branch selected
• add_issues_links
• allow-package-config-3
• badges
• bug-fixes
• ci_cleanup
• cleanup_silly
• cli-config-coverage
• cli-config-dev
• cli_config-sync
• cli_config_docs
• code-parsing
• cov_corner_case
• cov_filter_ignored
• cov_iso_hang
• cov_pub
• cov_rpc_error
• cov_workspaces
• cov_yaml
• coverage-flags-yaml
• coverage_main_isolate_sentinel
• coverage_require_dart_3_9
• coverage_update_mocks
• covpubprep
• cst-formal-model
• dependabot/github_actions/actions/checkout-3.5.0
• dependabot/github_actions/actions/checkout-3.5.2
• dependabot/github_actions/actions/checkout-3.5.3
• dependabot/github_actions/actions/checkout-3.6.0
• dependabot/github_actions/actions/checkout-4.1.0
• dependabot/github_actions/actions/checkout-4.1.1
• dependabot/github_actions/actions/checkout-4.1.2
• dependabot/github_actions/actions/checkout-4.1.4
• dependabot/github_actions/coverallsapp/github-action-2.0.0
• dependabot/github_actions/coverallsapp/github-action-2.1.2
• dependabot/github_actions/coverallsapp/github-action-2.2.0
• dependabot/github_actions/coverallsapp/github-action-2.2.1
• dependabot/github_actions/coverallsapp/github-action-2.2.3
• dependabot/github_actions/dart-lang/setup-dart-1.6.0
• dependabot/github_actions/dart-lang/setup-dart-1.6.2
• dependabot/github_actions/dart-lang/setup-dart-1.6.4
• dependabot/github_actions/github-actions-130e275bbf
• dependabot/github_actions/github-actions-4bbd769b2c
• dependabot/github_actions/github-actions-5cd08569fb
• dependabot/github_actions/github-actions-5f7181814f
• dependabot/github_actions/github-actions-642f5ae86e
• dependabot/github_actions/github-actions-6a5076a08d
• dependabot/github_actions/github-actions-821e67d316
• dependabot/github_actions/github-actions-9c54b75f35
• dependabot/github_actions/github-actions-aa3137d618
• dependabot/github_actions/github-actions-ad14d08c93
• dependabot/github_actions/github-actions-ceddc1e310
• dependabot/github_actions/github-actions-e6ee9d7de3
• dependabot/github_actions/github-actions-edf2abb101
• dependabot/github_actions/github-actions-f1e42714bc
• dependabot/github_actions/github-actions-f292acef55
• dependabot/github_actions/github-actions-fa0ebbeeaa
• dependabot/github_actions/github-actions-fae3105be2
• dependabot/github_actions/github-actions-fc897e6b79
• deploy_markdown_playground
• dropped_collections
• email-regex
• enable-tag-filter
• excerpter
• feat/language-version-package
• feat/preserve-fenced-code-block-metadata
• feature/fail_under
• fix-block-map-colon-offset
• fix-coverage-aot-cli-util
• fix-coverage-file-uri-arbitrary-read
• fix-flow-delimiter-comments
• fix-flow-list-trailing-comma
• fix-gfm-setext-header-list-precedence
• fix-license
• fix-line-ending-bug
• fix-list-append-chomping
• fix-list-indentation-fallback
• fix-markdown-quadratic-plaintext
• fix-perform-edit
• fix-scalar-crlf-header
• fix-unpinned-uses
• fix-windows
• fix520
• fix685
• fix_analysis
• fix_ci_infra
• fix_deploy_markdown
• fix_lints
• fix_markdown
• fix_single_element_map
• frame-condition-assertion
• handle-aliases
• have-ci-checks-run-for-all-PR-branches
• image
• improve-link-handling
• issue_links
• kevmoo-patch-1
• license_headers
• lint_cleanup
• main
• markdown
• markdown-header-anchor-link-text-1339
• markdown-remove-mirrors
• markdown-wip
• markdown-zombie-cleanup
• markdown/fenced-code-block-indent-handling
• markdown_example_cleanup
• markdown_fix_crash_test
• markdown_fix_doc_commetns
• markdown_lint
• markdown_silly
• md-html-multiline-comment
• merge-coverage-package
• merge-markdown-package
• merge-yaml_edit-package
• more-tests
• more_cleanup
• more_crash_test
• non-string-map-keys
• normalize_workflows
• optional-string-valid-values
• patch-exception-on-616
• patch-tests-for-588-2
• refs/pull/2472/merge
• refs/pull/2478/merge
• refs/pull/2485/merge
• remove-pub-run
• remove-read-all
• remove_options_dups
• resolve-paths-windows
• revert-2295-revert-2340a3a
• revert-2340a3a
• robustness-fixes
• setup_dart
• sortReadme
• string-list
• update_example
• update_markdown_example_html
• update_pkg_cli_config
• v0.1.0
• validate_setup_dart
• vm_service_15
• web_coverage
• yaml_edit-crash-test
• yaml_edit-zombie-cleanup
• yaml_edit_2.2.4

Build # 35479925079

Build Type

push

github

Committed by web-flow

Commit Message

chore(unified_analytics): remove dart:mirrors usage in test/event_test.dart (#2602)

`dart:mirrors` has been marked `@deprecated` on the bleeding-edge Dart SDK (`main` branch, [CL 541360](https://dart-review.googlesource.com/c/sdk/+/541360)) ahead of its planned removal in Dart 4.0 ([dart-lang/sdk#44489](https://github.com/dart-lang/sdk/issues/44489)).

### Changes
- Replace `reflectClass(Event).declarations` (`dart:mirrors`) in `pkgs/unified_analytics/test/event_test.dart` with `Isolate.resolvePackageUriSync` (`dart:isolate`), stripping comments (`//` and `/* ... */`) before matching `Event.<name>(` constructor identifiers and verifying exact unordered equality against `DashEvent.values` (excluding `DashEvent.ideEvent`) and `eventsAccountedForInTests`.
- `pubspec.yaml` and `CHANGELOG.md` are already at `8.0.19-wip`, and since this only touches `test/event_test.dart`, no new changelog entry is needed.

Coverage Stats

725 of 772 relevant lines covered (93.91%)

4.03 hits per line