decentraland / catalyst-client / 38602312773

82%

push

github

fix: return image bytes from getthumbnail and getimage (#495)

* fix: return image bytes from getThumbnail and getImage

The generated binary operations ask for a blob response, but the
fetcher always called response.json(), so both rejected with a JSON
parse error on every image. The fetcher now reads the body as bytes
for blob responses and keeps the response content type.

* fix: reject failed image downloads instead of returning the error body

A non-2xx response to getThumbnail/getImage resolved to a Blob holding
the error body. It now rejects with a ContentDownloadError carrying the
status and body (read so the connection is released). responseType is
narrowed to 'blob' | 'json'.

538 of 645 branches covered (83.41%)

Branch coverage included in aggregate %.

13 of 14 new or added lines in 4 files covered. (92.86%)

819 of 978 relevant lines covered (83.74%)

64.0 hits per line