supabase / storage / 38580303513

86%

push

github

fix(s3): reject repeated presigned header query values (#1508)

## What kind of change does this PR introduce?

Bug fix

## What is the current behavior?

A normal presigned metadata value is one query parameter and is stored.
A repeated `x-amz-*` parameter still passes the signature because the
array is comma joined. The metadata key is then skipped and the object
write succeeds without that value.

## What is the new behavior?

One string value is stored. A repeated `x-amz-*` parameter returns
`InvalidRequest` before the write.

Signed-off-by: Ferhat Elmas <elmas.ferhat@gmail.com>

7642 of 9478 branches covered (80.63%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

13321 of 15076 relevant lines covered (88.36%)

856.9 hits per line